De-conflict camera names and hostnames by use of a banner#1982
Merged
samfreund merged 21 commits intoPhotonVision:mainfrom Jul 4, 2025
Merged
De-conflict camera names and hostnames by use of a banner#1982samfreund merged 21 commits intoPhotonVision:mainfrom
samfreund merged 21 commits intoPhotonVision:mainfrom
Conversation
samfreund
force-pushed
the
deconflict-host-camera-names
branch
from
4c045f0 to
f90b38e
Compare
mcm001
reviewed
Jul 1, 2025
photon-core/src/main/java/org/photonvision/common/hardware/HardwareManager.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Jul 1, 2025
photon-core/src/main/java/org/photonvision/common/hardware/HardwareManager.java
Outdated
Show resolved
Hide resolved
samfreund
force-pushed
the
deconflict-host-camera-names
branch
from
4a3ae11 to
c1b3043
Compare
This comment was marked as outdated.
This comment was marked as outdated.
samfreund
force-pushed
the
deconflict-host-camera-names
branch
from
808c96f to
1581974
Compare
This comment was marked as outdated.
This comment was marked as outdated.
samfreund
force-pushed
the
deconflict-host-camera-names
branch
2 times, most recently
from
fcf6ff9 to
cae56f1
Compare
mcm001
reviewed
Jul 2, 2025
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Jul 2, 2025
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Jul 2, 2025
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Show resolved
Hide resolved
samfreund
force-pushed
the
deconflict-host-camera-names
branch
7 times, most recently
from
3da623d to
34d704b
Compare
lint NT manager lint network config lint backend update config for frontend interface
needed a bit more updating
samfreund
force-pushed
the
deconflict-host-camera-names
branch
from
34d704b to
61e4f7b
Compare
lint dashboard view initial debugging of frontend remove frontend loggers bah, forgot to lint lint and remove extraneous log
samfreund
force-pushed
the
deconflict-host-camera-names
branch
3 times, most recently
from
a35b646 to
b2d2ef6
Compare
Discard changes to photon-client/src/components/settings/NetworkingCard.vue Discard changes to photon-client/src/stores/settings/GeneralSettingsStore.ts Discard changes to photon-client/src/types/SettingTypes.ts Discard changes to photon-core/src/main/java/org/photonvision/common/configuration/NetworkConfig.java
samfreund
force-pushed
the
deconflict-host-camera-names
branch
from
b2d2ef6 to
01de694
Compare
samfreund
force-pushed
the
deconflict-host-camera-names
branch
3 times, most recently
from
c3cfc42 to
a1314dc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gold856
force-pushed
the
deconflict-host-camera-names
branch
from
8b46a90 to
c138e01
Compare
samfreund
force-pushed
the
deconflict-host-camera-names
branch
from
a81db6d to
52a1706
Compare
Member
Author
|
Change MAC to dashes early on. Big scary banner! |
samfreund
force-pushed
the
deconflict-host-camera-names
branch
from
52a1706 to
ed58922
Compare
Gold856
requested changes
Jul 4, 2025
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Show resolved
Hide resolved
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
Show resolved
Hide resolved
Gold856
force-pushed
the
deconflict-host-camera-names
branch
from
3032c4c to
065d44d
Compare
Gold856
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1918
All this does is warn the user when there's a conflict. Checking is done by publishing the hostname and camera names to NT using the MAC address as a key, then seeing if there are any other coprocs that did that and have the same names.